Changed the order of toolset and gyp CFLAGS, CXXFLAGS and LDFLAGS.

Changed the order of toolset and gyp CFLAGS, CXXFLAGS and LDFLAGS.

[asharif1, 2010-12-17 00:29:27]

Evan,

Thanks for the tip about controlling gyp beast.

Please review this.

Note that I am *NOT* a Chromium committer.

[Evan Martin, 2010-12-17 00:34:14]

Can you write a test?  I feel like this worked at one point and then regressed.

[asharif1, 2010-12-17 18:53:50]

On 2010/12/17 00:34:14, Evan Martin wrote:
> Can you write a test?  I feel like this worked at one point and then
regressed.

Trybot seems to have worked. I have managed to compile Chromium with -O1 and it
was built fine. -O3 gave me some problems with the Crosstool compiler and I've
filed a bug for that.

[Evan Martin, 2010-12-17 18:56:15]

On 2010/12/17 18:53:50, asharif1 wrote:
> On 2010/12/17 00:34:14, Evan Martin wrote:
> > Can you write a test?  I feel like this worked at one point and then
> regressed.
> 
> Trybot seems to have worked.

By test, I meant a gyp test that verifies that the change doesn't regress.

[asharif1, 2010-12-17 22:04:17]

Evan,

I'm new to gyp and the test that I wrote does not pass. Do you know where gyp
dumps all the temporary makefiles, etc. so I can take a look at it?

Let me know if the test looks good to you.

[Evan Martin, 2010-12-17 22:10:53]

If you export PRESERVE=1 before running the test it leaves the extra files
behind.

http://codereview.chromium.org/5917002/diff/6001/test/cxxflags/gyptest-cxxfla...
File test/cxxflags/gyptest-cxxflags.py (right):

http://codereview.chromium.org/5917002/diff/6001/test/cxxflags/gyptest-cxxfla...
test/cxxflags/gyptest-cxxflags.py:23: os.environ['CXXFLAGS'] = '-O0'
One idea to make this test simpler is to instead use a flag like
  -DFLAG_FROM_ENV=1
and that way you can #ifdef test it, rather than relying on __OPTIMIZE__.

[asharif1, 2010-12-17 23:00:05]

On 2010/12/17 22:10:53, Evan Martin wrote:
> If you export PRESERVE=1 before running the test it leaves the extra files
> behind.
> 
>
http://codereview.chromium.org/5917002/diff/6001/test/cxxflags/gyptest-cxxfla...
> File test/cxxflags/gyptest-cxxflags.py (right):
> 
>
http://codereview.chromium.org/5917002/diff/6001/test/cxxflags/gyptest-cxxfla...
> test/cxxflags/gyptest-cxxflags.py:23: os.environ['CXXFLAGS'] = '-O0'
> One idea to make this test simpler is to instead use a flag like
>   -DFLAG_FROM_ENV=1
> and that way you can #ifdef test it, rather than relying on __OPTIMIZE__.

Evan,

That test is already there (it's inside the defines directory).

I want to test the CXXFLAGS, CFLAGS and LDFLAGS.

This test now works with gyptest. Do I need to write more tests?

[asharif1, 2010-12-17 23:04:06]

On 2010/12/17 23:00:05, asharif1 wrote:
> On 2010/12/17 22:10:53, Evan Martin wrote:
> > If you export PRESERVE=1 before running the test it leaves the extra files
> > behind.
> > 
> >
>
http://codereview.chromium.org/5917002/diff/6001/test/cxxflags/gyptest-cxxfla...
> > File test/cxxflags/gyptest-cxxflags.py (right):
> > 
> >
>
http://codereview.chromium.org/5917002/diff/6001/test/cxxflags/gyptest-cxxfla...
> > test/cxxflags/gyptest-cxxflags.py:23: os.environ['CXXFLAGS'] = '-O0'
> > One idea to make this test simpler is to instead use a flag like
> >   -DFLAG_FROM_ENV=1
> > and that way you can #ifdef test it, rather than relying on __OPTIMIZE__.
> 
> Evan,
> 
> That test is already there (it's inside the defines directory).

What I meant was there is a defines test that changes defines and checks whether
they are being passed in. That test works and is already checked in. I want to
test the compiler flags.

> 
> I want to test the CXXFLAGS, CFLAGS and LDFLAGS.
> 
> This test now works with gyptest. Do I need to write more tests?

I just added CFLAGS test to it.

[Evan Martin, 2010-12-17 23:27:06]

Really sorry for all the extra work, but this looks almost perfect.

One other request: can you make the copyrights on your new file say 2010?

http://codereview.chromium.org/5917002/diff/17001/test/cxxflags/cxxflags.gyp
File test/cxxflags/cxxflags.gyp (right):

http://codereview.chromium.org/5917002/diff/17001/test/cxxflags/cxxflags.gyp#...
test/cxxflags/cxxflags.gyp:9: 'type': 'executable',
Should this include an opt flag setting?

It seems before we also obeyed CFLAGS from the environment; what your change is
changing is making sure CFLAGS from the environment override CFLAGS from the gyp
file.  So I think you should put some flag in this file to verify that your
environment setting is overriding it.

[Evan Martin, 2010-12-18 00:11:30]

LGTM