Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5934)

Unified Diff: chrome/browser/debugger/devtools_window.cc

Issue 5915006: Remove user-related data from local_state and add to user_preferences, i... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: svn pset Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/browser_window_gtk.cc » ('j') | chrome/browser/net/predictor_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_window.cc
===================================================================
--- chrome/browser/debugger/devtools_window.cc (revision 71191)
+++ chrome/browser/debugger/devtools_window.cc (working copy)
@@ -17,6 +17,7 @@
#include "chrome/browser/load_notification_details.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/renderer_host/render_view_host.h"
#include "chrome/browser/tab_contents/navigation_controller.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
@@ -216,20 +217,23 @@
wp_key.append("_");
wp_key.append(kDevToolsApp);
- PrefService* prefs = g_browser_process->local_state();
- if (!prefs->FindPreference(wp_key.c_str())) {
+ ProfileManager* profile_manager = g_browser_process->profile_manager();
+ if (profile_manager) {
+ PrefService* prefs = profile_manager->GetDefaultProfile()->GetPrefs();
prefs->RegisterDictionaryPref(wp_key.c_str());
apavlov 2011/01/18 00:33:03 I have no relation to this code, but the FindPrefe
- }
- const DictionaryValue* wp_pref = prefs->GetDictionary(wp_key.c_str());
- if (!wp_pref) {
- DictionaryValue* defaults = prefs->GetMutableDictionary(wp_key.c_str());
- defaults->SetInteger("left", 100);
- defaults->SetInteger("top", 100);
- defaults->SetInteger("right", 740);
- defaults->SetInteger("bottom", 740);
- defaults->SetBoolean("maximized", false);
- defaults->SetBoolean("always_on_top", false);
+ const DictionaryValue* wp_pref = prefs->GetDictionary(wp_key.c_str());
+ if (!wp_pref) {
+ DictionaryValue* defaults = prefs->GetMutableDictionary(wp_key.c_str());
+ defaults->SetInteger("left", 100);
+ defaults->SetInteger("top", 100);
+ defaults->SetInteger("right", 740);
+ defaults->SetInteger("bottom", 740);
+ defaults->SetBoolean("maximized", false);
+ defaults->SetBoolean("always_on_top", false);
+ }
+ } else {
+ NOTREACHED() << "browser process does not have a ProfileManager.";
}
browser_ = Browser::CreateForDevTools(profile_);
« no previous file with comments | « no previous file | chrome/browser/gtk/browser_window_gtk.cc » ('j') | chrome/browser/net/predictor_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698