Introduce incognito preference settings.

chrome/browser/prefs/overlay_persistent_pref_store.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_OVERLAY_PERSISTENT_PREF_STORE_H_
+#define CHROME_BROWSER_PREFS_OVERLAY_PERSISTENT_PREF_STORE_H_
+#pragma once
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/observer_list.h"
+#include "base/ref_counted.h"
+#include "chrome/browser/prefs/pref_value_map.h"
+#include "chrome/common/persistent_pref_store.h"
+
+class OverlayPersistentPrefStore : public PersistentPrefStore,

[Mattias Nissler (ping if slow), 2010/12/20 14:50:02]

Could use a class comment describing the behavior of this PersistentPrefStore
implementation.

[battre, 2010/12/21 18:51:59]

Done.

+                                   public PrefStore::Observer {
+ public:
+  // Creates an overlay pref store. Assumes ownership of |overlay| but keeps
+  // underlay as a weak pointer.

[Mattias Nissler (ping if slow), 2010/12/20 14:50:02]

A scoped_refptr is not weak.

[battre, 2010/12/21 18:51:59]

Done.

+  explicit OverlayPersistentPrefStore(
+      scoped_refptr<PersistentPrefStore> underlay);
+  virtual ~OverlayPersistentPrefStore();
+
+  // Methods of PrefStore.
+  virtual void AddObserver(PrefStore::Observer* observer);
+  virtual void RemoveObserver(PrefStore::Observer* observer);
+  virtual bool IsInitializationComplete() const;
+  virtual ReadResult GetValue(const std::string& key, Value** result) const;
+
+  // Methods of PersistentPrefStore.
+  virtual void SetValue(const std::string& key, Value* value);
+  virtual void SetValueSilently(const std::string& key, Value* value);
+  virtual void RemoveValue(const std::string& key);
+  virtual bool ReadOnly() const;
+  virtual PrefReadError ReadPrefs();
+  virtual bool WritePrefs();
+  virtual void ScheduleWritePrefs();
+
+ private:
+  // Methods of PrefStore::Observer.
+  virtual void OnPrefValueChanged(const std::string& key);
+  virtual void OnInitializationCompleted();
+
+  ObserverList<PrefStore::Observer, true> observers_;
+  PrefValueMap overlay_;
+  scoped_refptr<PersistentPrefStore> underlay_;
+
+  DISALLOW_COPY_AND_ASSIGN(OverlayPersistentPrefStore);
+};
+
+#endif  // CHROME_BROWSER_PREFS_OVERLAY_PERSISTENT_PREF_STORE_H_