Make it so that chrome.bookmarks.update can update the URL of a bookmark....

Make it so that chrome.bookmarks.update can update the URL of a bookmark.

This changes the API slightly. Previously, if someone called update with an empty object ({}) it would set the title to "". This was only documented in the code and not on the API page. Now that we support updating both the url and title it seems more reasonable to ignore a missing title.

BUG=34841
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38555

[arv (Not doing code reviews), 2010-02-08 23:55:24]

This one depends on http://codereview.chromium.org/582022/show

This changes the API slightly. Previously, if someone called update with an
empty object ({}) it would set the title to "". This was only documented in the
code and not on the API page. Now that we support updating both the url and
title it seems more reasonable to ignore a missing title.

When I run the build script it picked up some changes to tabs.html. Do you want
me to revert those?

[rafaelw, 2010-02-09 00:13:56]

I forgot to generate docs for http://codereview.chromium.org/558049 (I'm not
sure why the PRESUBMIT didn't warn me).

Anyhow. Arv, the changes to tabs.html are from that. Go ahead and check them in.
The "null" className is unfortunate, but I don't think it'll break anything.

[Erik does not do reviews, 2010-02-09 00:15:42]

LGTM

http://codereview.chromium.org/591006/diff/3001/3002
File chrome/browser/extensions/extension_bookmarks_module.cc (right):

http://codereview.chromium.org/591006/diff/3001/3002#newcode647
chrome/browser/extensions/extension_bookmarks_module.cc:647: // Optional but we
need to distinguish non present from an empty title.
nit: newline above comment

http://codereview.chromium.org/591006/diff/3001/3002#newcode654
chrome/browser/extensions/extension_bookmarks_module.cc:654: // If URL is
present then it needs to be a non empty valid URL.
nit: newline above comment