Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: scm.py

Issue 591002: Fix failure to contain the line entry instead of constant "True" (Closed)
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 48118d10357ed2f4872271c844aad22cd26ea531..1dce4bd7ccd9d35dd6e3a8b09788c70c03a8036d 100644
--- a/scm.py
+++ b/scm.py
@@ -369,9 +369,7 @@ class SVN(object):
if match:
file_list.append(match.group(1))
if line.startswith('svn: '):
- # We can't raise an exception. We can't alias a variable. Use a cheap
- # way.
- failure.append(True)
+ failure.append(line)
try:
SVN.RunAndFilterOutput(args,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698