Issue 5910004: Fixing indentation spacing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5910004: Fixing indentation spacing (Closed)

Created:
10 years ago by msw

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fixing indentation spacing from r69422 for Issue 14748. (I missed brettw's final comment to fix this in http://codereview.chromium.org/5774004/) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69486

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/autocomplete/history_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

10 years ago (2010-12-16 23:45:32 UTC) #2

Done.

On Thu, Dec 16, 2010 at 3:42 PM,  <msw@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> Please help me land this; I can git try if you want...
>
> Description:
> Fixing indentation spacing from r69422 for Issue 14748.
> (I missed brettw's final comment to fix this in
> http://codereview.chromium.org/5774004/)
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/5910004/
>
> SVN Base: http://git.chromium.org/git/chromium.git@trunk
>
> Affected files:
>  M chrome/browser/autocomplete/history_provider.cc
>
>
> Index: chrome/browser/autocomplete/history_provider.cc
> diff --git a/chrome/browser/autocomplete/history_provider.cc
> b/chrome/browser/autocomplete/history_provider.cc
> index
>
6d0af1e4942a74c5d85b58736031aebfd192a48c..100db041840c45e4169904c915312ad01528d03c
> 100644
> --- a/chrome/browser/autocomplete/history_provider.cc
> +++ b/chrome/browser/autocomplete/history_provider.cc
> @@ -28,7 +28,7 @@ void HistoryProvider::DeleteMatch(const AutocompleteMatch&
> match) {
>   DCHECK(match.deletable);
>
>   HistoryService* const history_service =
> -    profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
> +      profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
>
>   // Delete the match from the history DB.
>   GURL selected_url(match.destination_url);
>
>
>

Expand Messages | Collapse Messages