Issue 5906001: Makes linux honor instant_is_active when instant temporarily hides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5906001: Makes linux honor instant_is_active when instant temporarily hides. (Closed)

Created:
10 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Makes linux honor instant_is_active when instant temporarily hides. BUG=66720 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69373

Patch Set 2 : true #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/5906001/diff/1/chrome/browser/gtk/browser_window_gtk.cc File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/5906001/diff/1/chrome/browser/gtk/browser_window_gtk.cc#newcode1114 chrome/browser/gtk/browser_window_gtk.cc:1114: contents->FadeForInstant(false); true?

10 years ago (2010-12-15 20:50:26 UTC) #2

sky

10 years ago (2010-12-15 21:07:58 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 5906001: Makes linux honor instant_is_active when instant temporarily hides. (Closed)

Description

Patch Set 1 #

Patch Set 2 : true #

Messages