Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 5906001: Makes linux honor instant_is_active when instant temporarily hides. (Closed)

Created:
10 years ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Makes linux honor instant_is_active when instant temporarily hides. BUG=66720 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69373

Patch Set 1 #

Total comments: 2

Patch Set 2 : true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/gtk/browser_window_gtk.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
10 years ago (2010-12-15 17:03:40 UTC) #1
Evan Stade
http://codereview.chromium.org/5906001/diff/1/chrome/browser/gtk/browser_window_gtk.cc File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/5906001/diff/1/chrome/browser/gtk/browser_window_gtk.cc#newcode1114 chrome/browser/gtk/browser_window_gtk.cc:1114: contents->FadeForInstant(false); true?
10 years ago (2010-12-15 20:50:26 UTC) #2
sky
http://codereview.chromium.org/5906001/diff/1/chrome/browser/gtk/browser_window_gtk.cc File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/5906001/diff/1/chrome/browser/gtk/browser_window_gtk.cc#newcode1114 chrome/browser/gtk/browser_window_gtk.cc:1114: contents->FadeForInstant(false); On 2010/12/15 20:50:26, Evan Stade wrote: > true? ...
10 years ago (2010-12-15 21:07:58 UTC) #3
Evan Stade
10 years ago (2010-12-16 00:43:11 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698