Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 5904002: Add heapcheck suppression for NSS trust leak. (Closed)

Created:
10 years ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
wtc, James Hawkins
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add heapcheck suppression for NSS certificate trust leak. BUG=66941 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69376

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M tools/heapcheck/suppressions.txt View 1 chunk +19 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
TBR jhawkins, as you are listed as the current memory sheriff. This is just the ...
10 years ago (2010-12-16 04:45:21 UTC) #1
James Hawkins
LGTM
10 years ago (2010-12-16 04:46:30 UTC) #2
wtc
http://codereview.chromium.org/5904002/diff/4001/tools/heapcheck/suppressions.txt File tools/heapcheck/suppressions.txt (right): http://codereview.chromium.org/5904002/diff/4001/tools/heapcheck/suppressions.txt#newcode107 tools/heapcheck/suppressions.txt:107: fun:PR_NewLock The suppressions should all include CERT_ChangeCertTrust in the ...
10 years ago (2010-12-17 02:46:59 UTC) #3
Ryan Sleevi
10 years ago (2010-12-17 02:50:17 UTC) #4
http://codereview.chromium.org/5904002/diff/4001/tools/heapcheck/suppressions...
File tools/heapcheck/suppressions.txt (right):

http://codereview.chromium.org/5904002/diff/4001/tools/heapcheck/suppressions...
tools/heapcheck/suppressions.txt:107: fun:PR_NewLock
On 2010/12/17 02:46:59, wtc wrote:
> The suppressions should all include CERT_ChangeCertTrust
> in the call stacks.
> 
> In fact, I think it's fine to merge these into a single
> suppression with this call stack:
>   fun:CERT_ChangeCertTrust
>   fun:net::TestRootCerts::*

wtc: Unfortunately, heapcheck wasn't picking up CERT_ChangeCertTrust as part of
the callstack. The suppressions went straight from Add/Clear into these three
functions. Otherwise, I would have just suppressed CERT_ChangeCertTrust without
the TestRootCerts, which is what I did for the Valgrind suppression.

Powered by Google App Engine
This is Rietveld 408576698