Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 5903003: Add flag for running with a non standard number of stress-runs.... (Closed)

Created:
10 years ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add flag for running with a non standard number of stress-runs. This allows easy testing with more than 5/2 stress runs in release/debug and will allow us to have a nightly run with e.g., 10 stress runs in debug mode. Committed: http://code.google.com/p/v8/source/detail?r=6050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
10 years ago (2010-12-16 12:39:56 UTC) #1
Mads Ager (chromium)
LGTM
10 years ago (2010-12-16 13:22:26 UTC) #2
Søren Thygesen Gjesse
10 years ago (2010-12-16 14:10:09 UTC) #3
On 2010/12/16 13:22:26, Mads Ager wrote:
> LGTM

I would suggest to add this option to the shell only, and add it as an argument
to the v8::Testing::SetStressRunType. The reason for this is that when this is
used for the reliability tests the test driver and the render are not the same
process.

It could also be an argument to the current --stress-opt, --stress-opt=10

Powered by Google App Engine
This is Rietveld 408576698