Two fixes for the virtual keyboard.

Two fixes for the virtual keyboard.

1) Fix layout by setting the bounds.  Oops!
2) Fix the spurious hiding.

BUG=none
TEST=keyboard now appears when a text field is focused in a touchui build, even immediately after browser initialization

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69358

[sky, 2010-12-15 17:05:33]

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
File chrome/browser/ui/touch/frame/touch_browser_frame_view.cc (right):

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:81: if (!keyboard_)
Why do we need this check?

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:84: if
(should_show_keyboard == keyboard_->IsVisible())
Shouldn't this be keyboard_showing_ ?

[bryeung, 2010-12-15 18:02:00]

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
File chrome/browser/ui/touch/frame/touch_browser_frame_view.cc (right):

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:81: if (!keyboard_)
On 2010/12/15 17:05:33, sky wrote:
> Why do we need this check?

As discussed in the other CL, if we want to be ignoring all calls to this
function before the first time the keyboard is shown.  This check combined with
the if above that conditionally initializes the keyboard accomplish this.

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:84: if
(should_show_keyboard == keyboard_->IsVisible())
On 2010/12/15 17:05:33, sky wrote:
> Shouldn't this be keyboard_showing_ ?

I thought it would be better to rely on the actual View for this, but maybe it
is better for everything to use the same check.

Fixed.

[sky, 2010-12-15 18:11:49]

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
File chrome/browser/ui/touch/frame/touch_browser_frame_view.cc (right):

http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:81: if (!keyboard_)
On 2010/12/15 18:02:01, bryeung wrote:
> On 2010/12/15 17:05:33, sky wrote:
> > Why do we need this check?
> 
> As discussed in the other CL, if we want to be ignoring all calls to this
> function before the first time the keyboard is shown.

In that case won't should_show_keyboard_ == keyboard_showing_, and you do
nothing?

[bryeung, 2010-12-15 18:15:52]

On 2010/12/15 18:11:49, sky wrote:
>
http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
> File chrome/browser/ui/touch/frame/touch_browser_frame_view.cc (right):
> 
>
http://codereview.chromium.org/5903002/diff/1/chrome/browser/ui/touch/frame/t...
> chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:81: if (!keyboard_)
> On 2010/12/15 18:02:01, bryeung wrote:
> > On 2010/12/15 17:05:33, sky wrote:
> > > Why do we need this check?
> > 
> > As discussed in the other CL, if we want to be ignoring all calls to this
> > function before the first time the keyboard is shown.
> 
> In that case won't should_show_keyboard_ == keyboard_showing_, and you do
> nothing?

That's a good point.  This would be better as a simple DCHECK(keyboard_) to
satisfy my desire for safety instead.

Fixed.

[sky, 2010-12-15 18:34:37]

LGTM