Issue 59004: Use the better gyp pattern to make sure test_shell.pak is installed next...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59004: Use the better gyp pattern to make sure test_shell.pak is installed next... (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use the better gyp pattern to make sure test_shell.pak is installed next to test_shell on Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12976

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	webkit/tools/test_shell/test_shell.gyp	View		1 chunk	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 8 months ago (2009-04-02 05:07:19 UTC) #2

LGTM 1.0

http://codereview.chromium.org/59004/diff/1/2
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/59004/diff/1/2#newcode173
Line 173: '<(INTERMEDIATE_DIR)/repack/test_shell.pak',
I thought this was fine as-is, but it seems that you're doing this to avoid
scons_depends.

This LGTM, but perhaps we should revisit actions to make the dependency implicit
as GYP seems to expect.

Expand Messages | Collapse Messages