Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 5900001: Fix deoptimization from %_MathPow. Do not prepare the stack for a C... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1585 matching lines...) Expand 10 before | Expand all | Expand 10 after
1596 ASSERT(instr->representation().IsDouble()); 1596 ASSERT(instr->representation().IsDouble());
1597 // We call a C function for double power. It can't trigger a GC. 1597 // We call a C function for double power. It can't trigger a GC.
1598 // We need to use fixed result register for the call. 1598 // We need to use fixed result register for the call.
1599 Representation exponent_type = instr->right()->representation(); 1599 Representation exponent_type = instr->right()->representation();
1600 ASSERT(instr->left()->representation().IsDouble()); 1600 ASSERT(instr->left()->representation().IsDouble());
1601 LOperand* left = UseFixedDouble(instr->left(), xmm1); 1601 LOperand* left = UseFixedDouble(instr->left(), xmm1);
1602 LOperand* right = exponent_type.IsDouble() ? 1602 LOperand* right = exponent_type.IsDouble() ?
1603 UseFixedDouble(instr->right(), xmm2) : 1603 UseFixedDouble(instr->right(), xmm2) :
1604 UseFixed(instr->right(), eax); 1604 UseFixed(instr->right(), eax);
1605 LPower* result = new LPower(left, right); 1605 LPower* result = new LPower(left, right);
1606 return MarkAsCall(DefineFixedDouble(result, xmm1), instr, 1606 return MarkAsCall(DefineFixedDouble(result, xmm3), instr,
1607 CAN_DEOPTIMIZE_EAGERLY); 1607 CAN_DEOPTIMIZE_EAGERLY);
1608 } 1608 }
1609 1609
1610 1610
1611 LInstruction* LChunkBuilder::DoCompare(HCompare* instr) { 1611 LInstruction* LChunkBuilder::DoCompare(HCompare* instr) {
1612 Token::Value op = instr->token(); 1612 Token::Value op = instr->token();
1613 if (instr->left()->representation().IsInteger32()) { 1613 if (instr->left()->representation().IsInteger32()) {
1614 ASSERT(instr->right()->representation().IsInteger32()); 1614 ASSERT(instr->right()->representation().IsInteger32());
1615 LOperand* left = UseRegisterAtStart(instr->left()); 1615 LOperand* left = UseRegisterAtStart(instr->left());
1616 LOperand* right = UseOrConstantAtStart(instr->right()); 1616 LOperand* right = UseOrConstantAtStart(instr->right());
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
2131 void LPointerMap::PrintTo(StringStream* stream) const { 2131 void LPointerMap::PrintTo(StringStream* stream) const {
2132 stream->Add("{"); 2132 stream->Add("{");
2133 for (int i = 0; i < pointer_operands_.length(); ++i) { 2133 for (int i = 0; i < pointer_operands_.length(); ++i) {
2134 if (i != 0) stream->Add(";"); 2134 if (i != 0) stream->Add(";");
2135 pointer_operands_[i]->PrintTo(stream); 2135 pointer_operands_[i]->PrintTo(stream);
2136 } 2136 }
2137 stream->Add("} @%d", position()); 2137 stream->Add("} @%d", position());
2138 } 2138 }
2139 2139
2140 } } // namespace v8::internal 2140 } } // namespace v8::internal
OLDNEW
« src/ia32/lithium-codegen-ia32.cc ('K') | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698