Issue 5898003: HHasInstanceType uses GVN but does not provide a comparison function...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5898003: HHasInstanceType uses GVN but does not provide a comparison function... (Closed)

Created:
10 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

A number of instructions use GVN but do not provide a comparison function for the data. This leads to wrong results where operations are wrongly assumed to have the same value as a previous (different) operation. Provide the data comparison functions. BUG=995 Committed: http://code.google.com/p/v8/source/detail?r=6052

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -0 lines)			Patch
	M	src/hydrogen-instructions.h	View	1	4 chunks	+24 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-995.js	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years ago (2010-12-16 15:40:46 UTC) #2

Other instructions fixed as well. Thanks for reminding me to check!

Expand Messages | Collapse Messages