Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 5898001: Fix issue 982. (Closed)

Created:
10 years ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 982. When splitting at the beginning of a use interval assign coinciding position to the split child instead of leaving it to parent. BUG=v8:982 Committed: http://code.google.com/p/v8/source/detail?r=6031

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M src/lithium-allocator.cc View 2 chunks +19 lines, -4 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
10 years ago (2010-12-15 13:52:55 UTC) #1
Kevin Millikin (Chromium)
10 years ago (2010-12-15 14:01:52 UTC) #2
LGTM.

http://codereview.chromium.org/5898001/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):

http://codereview.chromium.org/5898001/diff/1/src/lithium-allocator.cc#newcod...
src/lithium-allocator.cc:300: // If split position coincides with the beginning
of use interval
"the split position"..."a use interval" :)

http://codereview.chromium.org/5898001/diff/1/src/lithium-allocator.cc#newcod...
src/lithium-allocator.cc:331: while (use_after != NULL &&
use_after->pos().Value() < position.Value()) {
Maybe this case needs a short comment too, something like "We are splitting at
the start of an interval.  The use position at the start of the interval belongs
after the split."

Powered by Google App Engine
This is Rietveld 408576698