Chromium Code Reviews

Issue 5895005: Add 'en' in addition to 'en-US' as Accept-Language. (Closed)

Created:
10 years ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
mazda
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add 'en' in addition to 'en-US' as Accept-Language. Some web sites don't understand 'en-US' but 'en' in Accept-Language header. Hence we should add 'en' in addition to 'en-US'. BUG=chromium-os:9884 TEST=Added Finnish and confirmed that Accept-Language looked like "en-US,en;q=0.8,fi;q=0.6" using http://pgl.yoyo.org/http/browser-headers.php. Also visited sidneyspage.blogspot.com and confirmed that English contents were shown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69521

Patch Set 1 #

Patch Set 2 : rework comments #

Unified diffs Side-by-side diffs Stats (+31 lines, -6 lines)
M chrome/browser/resources/options/chromeos_language_list.js View 1 chunk +31 lines, -6 lines 0 comments

Messages

Total messages: 2 (0 generated)
satorux1
10 years ago (2010-12-17 05:40:45 UTC) #1
mazda
10 years ago (2010-12-17 05:54:40 UTC) #2
lgtm

Powered by Google App Engine