Issue 5890003: Make V8 compilable with profiling support turned off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5890003: Make V8 compilable with profiling support turned off. (Closed)

Created:
10 years ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make V8 compilable with profiling support turned off. BUG=990 Committed: http://code.google.com/p/v8/source/detail?r=6044

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -2 lines)			Patch
M	src/log.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/runtime-profiler.cc	View	4 chunks	+6 lines, -0 lines	0 comments	Download
M	src/top.cc	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	tools/test.py	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

On 2010/12/16 10:46:29, Michail Naganov wrote: I think, we need to streamling 'prof' vs. 'profiling' ...

10 years ago (2010-12-16 10:48:20 UTC) #2

Søren Thygesen Gjesse

10 years ago (2010-12-16 11:13:08 UTC) #3

What I think we need to do here is to have the VM state tracking always enabled
as this is what the crankshaft runtime profiler uses. So I think we should get
rid of ENABLE_VMSTATE_TRACKING altogether. Then have only
ENABLE_LOGGING_AND_PROFILING for the developer facing additional runtime
profiler parts.

If you build with profilingsupport=off you should get the same results on the
benchmarks, so that crankshaft is not disabled by compiling without profiling
support.

Expand Messages | Collapse Messages