Issue 5885001: Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5885001: Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h.... (Closed)

Created:
10 years ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h. BUG=28083 TEST=none Review URL: http://codereview.chromium.org/3549010 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69239

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -148 lines)			Patch
M	base/callback.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	base/raw_scoped_refptr_mismatch_checker.h	View	1 chunk	+130 lines, -89 lines	0 comments	Download
M	base/task.h	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	base/template_util.h	View	2 chunks	+0 lines, -47 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

10 years ago (2010-12-15 08:48:04 UTC) #3

Thanks for the revert.  FYI, I have a fix and plan to reland tonight so more
regressions don't trickle in.

On Wed, Dec 15, 2010 at 12:32 AM, <phajdan.jr@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h.
>
> BUG=28083
> TEST=none
>
> Review URL: http://codereview.chromium.org/3549010
>
> TBR=willchan@chromium.org
>
> Please review this at http://codereview.chromium.org/5885001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/callback.h
>  M     base/raw_scoped_refptr_mismatch_checker.h
>  M     base/task.h
>  M     base/template_util.h
>
>
>

Expand Messages | Collapse Messages