Issue 5884004: Fix discovering of stable candidate with unstable ebuilds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5884004: Fix discovering of stable candidate with unstable ebuilds. (Closed)

Created:
10 years ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Fix discovering of stable candidate with unstable ebuilds. Also add some more information output when we detect that there is nothing to do. Change-Id: Ia3dcf0d3c276e10d3368d6bd508f3a0d72be79cd BUG=chromium-os:8693 TEST=Ran it with all 3 paramaters and current overlay. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f19dea5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix regex for versions. #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	bin/cros_mark_chrome_as_stable.py	View	1	4 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

http://codereview.chromium.org/5884004/diff/1/bin/cros_mark_chrome_as_stable.py File bin/cros_mark_chrome_as_stable.py (right): http://codereview.chromium.org/5884004/diff/1/bin/cros_mark_chrome_as_stable.py#newcode172 bin/cros_mark_chrome_as_stable.py:172: if '9999' in ebuild.version: Since we're commiting unstable ebuilds ...

10 years ago (2010-12-16 19:11:34 UTC) #1

LGTM

Expand Messages | Collapse Messages