Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 5883003: Fix issue 974. (Closed)

Created:
10 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 974. When entering a finally block in unoptimized code, we unconditionally save the accumulator register in the stack in case it holds a return value or an exception. In the case of a break, continue, or falling off the end of the try or catch block, this value is unpredictable and not necessarily safe for GC. Committed: http://code.google.com/p/v8/source/detail?r=6035

Patch Set 1 #

Patch Set 2 : Better instruction sequence for x64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +14 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-974.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years ago (2010-12-15 16:05:49 UTC) #1
Mads Ager (chromium)
10 years ago (2010-12-15 16:12:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698