Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 5880002: (Committing on behalf of Chris Rogers -- original CL... (Closed)

Created:
10 years ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, Alpha Left Google, ddorwin+watch_chromium.org, sjl, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, scherkus (not reviewing)
Visibility:
Public.

Description

(Committing on behalf of Chris Rogers -- original CL http://codereview.chromium.org/5550006/ ) Implement WebKitClientImpl::loadAudioResource() to decode in-memory audio file data for use by WebKit. Most of the interesting low-level code is being added in the media directory. BUG=NONE TEST=NONE (tested locally with web audio API loading files of format .wav .aif .mp3 .m4a 16bit 24bit In the longer term, WebKit layout tests will comprehensively exercise this code) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69458

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -1 line) Patch
M media/audio/audio_util.h View 2 chunks +14 lines, -1 line 0 comments Download
M media/audio/audio_util.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A media/filters/audio_file_reader.h View 1 chunk +79 lines, -0 lines 0 comments Download
A media/filters/audio_file_reader.cc View 1 chunk +226 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A webkit/glue/media/audio_decoder.h View 1 chunk +20 lines, -0 lines 0 comments Download
A webkit/glue/media/audio_decoder.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698