Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: webkit/glue/media/video_renderer_impl.h

Issue 5878007: Fix black video frames when seeking (which also fixes flashing poster issue). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/media/video_renderer_impl.cc » ('j') | webkit/glue/media/video_renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/media/video_renderer_impl.h
diff --git a/webkit/glue/media/video_renderer_impl.h b/webkit/glue/media/video_renderer_impl.h
index 34c67d3e01b67a8a6d6b7476f26cf5e7de108adc..b8ff73dfb9f23ab793f85c20b03d6bd355be5ee4 100644
--- a/webkit/glue/media/video_renderer_impl.h
+++ b/webkit/glue/media/video_renderer_impl.h
@@ -31,6 +31,10 @@ class VideoRendererImpl : public WebVideoRenderer {
virtual void SetWebMediaPlayerImplProxy(WebMediaPlayerImpl::Proxy* proxy);
virtual void SetRect(const gfx::Rect& rect);
virtual void Paint(skia::PlatformCanvas* canvas, const gfx::Rect& dest_rect);
+ virtual bool GetCurrentBitmap(SkBitmap* bitmap);
+ virtual void CopyBitmapToCanvas(const SkBitmap& bitmap,
+ skia::PlatformCanvas* canvas,
+ const gfx::Rect& dest_rect);
virtual void GetCurrentFrame(scoped_refptr<media::VideoFrame>* frame_out);
virtual void PutCurrentFrame(scoped_refptr<media::VideoFrame> frame);
@@ -49,10 +53,8 @@ class VideoRendererImpl : public WebVideoRenderer {
// fast paint otherwise false.
bool CanFastPaint(skia::PlatformCanvas* canvas, const gfx::Rect& dest_rect);
- // Slow paint does a YUV => RGB, and scaled blit in two separate operations.
- void SlowPaint(media::VideoFrame* video_frame,
- skia::PlatformCanvas* canvas,
- const gfx::Rect& dest_rect);
+ // Slow paint does a YUV => RGB conversion.
+ void SlowPaintToBitmap(media::VideoFrame* video_frame, SkBitmap* bitmap);
// Fast paint does YUV => RGB, scaling, blitting all in one step into the
// canvas. It's not always safe and appropriate to perform fast paint.
« no previous file with comments | « no previous file | webkit/glue/media/video_renderer_impl.cc » ('j') | webkit/glue/media/video_renderer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698