Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 5878006: moving mocks into webkit/mocks/ (Closed)

Created:
10 years ago by annacc
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, sjl, acolwell GONE FROM CHROMIUM, darin-cc_chromium.org, awong, Paweł Hajdan Jr., pam+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

moving mocks into webkit/mocks/ The number of mock_... files in webkit/glue is piling up and it makes more sense for them to live in a brand new mocks/ directory. BUG=None. TEST=Compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webkit/glue/media/buffered_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/media/buffered_resource_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/media/simple_data_source_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/mocks/mock_resource_loader_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/mocks/mock_webframe.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/mocks/mock_weburlloader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
annacc
10 years ago (2010-12-17 02:16:38 UTC) #1
scherkus (not reviewing)
should the old files be marked as deleted? maybe rietveld doesn't display it correctly :\
10 years ago (2010-12-17 15:14:37 UTC) #2
annacc
yep, I thought the same thing at first, so I double checked. rietveld shows them ...
10 years ago (2010-12-17 15:48:21 UTC) #3
scherkus (not reviewing)
nifty! LGTM
10 years ago (2010-12-17 15:59:48 UTC) #4
darin (slow to review)
10 years ago (2010-12-17 17:25:01 UTC) #5
Thanks!

On Thu, Dec 16, 2010 at 6:16 PM, <annacc@chromium.org> wrote:

> Reviewers: scherkus, darin,
>
> Description:
> moving mocks into webkit/mocks/
>
> The number of mock_... files in webkit/glue is piling up and it makes more
> sense
> for them to live in a brand new mocks/ directory.
>
> BUG=None.
> TEST=Compiles.
>
> Please review this at http://codereview.chromium.org/5878006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M webkit/glue/media/buffered_data_source_unittest.cc
>  M webkit/glue/media/buffered_resource_loader_unittest.cc
>  M webkit/glue/media/simple_data_source_unittest.cc
>  A + webkit/mocks/mock_resource_loader_bridge.h
>  A + webkit/mocks/mock_webframe.h
>  A + webkit/mocks/mock_weburlloader.h
>  M webkit/tools/test_shell/test_shell.gypi
>
>
>

Powered by Google App Engine
This is Rietveld 408576698