Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 5877004: DOMUI Prefs: Remove border from list seletion, per mocks clarification (Closed)

Created:
10 years ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI Prefs: Remove border from list seletion, per mocks clarification BUG=None TEST=Selected list elements in DOMUI prefs should not have a dark border. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/resources/options/browser_options_page.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/startup_page_manager.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
10 years ago (2010-12-16 00:40:53 UTC) #1
Evan Stade
lgtm
10 years ago (2010-12-16 00:42:42 UTC) #2
arv (Not doing code reviews)
Please make sure that one can see which element is the lead item. Steps to ...
10 years ago (2010-12-16 00:57:39 UTC) #3
stuartmorgan
On Wed, Dec 15, 2010 at 4:57 PM, Erik Arvidsson <arv@chromium.org> wrote: > Please make ...
10 years ago (2010-12-16 01:08:18 UTC) #4
arv (Not doing code reviews)
10 years ago (2010-12-16 01:30:00 UTC) #5
Which UX designer?

OSX doesn't use that concept and most mac users do not know how to use
a keyboard (/me ducks)

erik



On Wed, Dec 15, 2010 at 17:08, Stuart Morgan <stuartmorgan@chromium.org> wrote:
> On Wed, Dec 15, 2010 at 4:57 PM, Erik Arvidsson <arv@chromium.org> wrote:
>> Please make sure that one can see which element is the lead item.
>
> That's what we had before, but the latest direction from UI is not to
> have any special decoration. You can take that up with the UI folks if
> you feel strongly about it.
>
> (Note that OS X has never had any indication of the lead, and I have
> never heard anyone complain about it, so I wouldn't expect this to be
> a significant concern.)
>
> -Stuart
>

Powered by Google App Engine
This is Rietveld 408576698