Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 5877001: Don't show duplicate Autofill suggestions. (Closed)

Created:
10 years ago by Ilya Sherman
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, Ilya Sherman, Paweł Hajdan Jr., James Hawkins, dhollowa
Visibility:
Public.

Description

Don't show duplicate Autofill suggestions. BUG=65133 TEST=unit_tests --gtest_filter=AutoFillManagerTest.GetProfileSuggestionsWithDuplicates Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69380

Patch Set 1 #

Total comments: 2

Patch Set 2 : don't #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -31 lines) Patch
M chrome/browser/autofill/autofill_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 3 chunks +28 lines, -29 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ilya Sherman
10 years ago (2010-12-15 05:00:04 UTC) #1
dhollowa
LGTM. http://codereview.chromium.org/5877001/diff/1/chrome/browser/autofill/autofill_manager.cc File chrome/browser/autofill/autofill_manager.cc (right): http://codereview.chromium.org/5877001/diff/1/chrome/browser/autofill/autofill_manager.cc#newcode261 chrome/browser/autofill/autofill_manager.cc:261: // autocomplete: Don't display or icons, as that ...
10 years ago (2010-12-16 03:57:12 UTC) #2
dhollowa
10 years ago (2010-12-16 15:58:27 UTC) #3
http://codereview.chromium.org/5877001/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/5877001/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_manager.cc:261: // autocomplete: Don't display
or icons, as that information is redundant.
On 2010/12/16 03:57:12, dhollowa wrote:
> "don't display labels or icons"

Missed "labels".

Powered by Google App Engine
This is Rietveld 408576698