Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5875005: Cleanup: Remove unneeded includes of notification_service.h.... (Closed)

Created:
10 years ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, native-client-reviews_googlegroups.com, tim (not reviewing)
Visibility:
Public.

Description

Cleanup: Remove unneeded includes of notification_service.h. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69507

Patch Set 1 #

Patch Set 2 : fix win #

Patch Set 3 : put includes in right order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -81 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_resource_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/extension_port_container.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background_application_list_model.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/debugger/extension_ports_remote_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_thumbnail_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/history2_ui.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/about_page_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/options/core_options_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/options/font_settings_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/options_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_idle_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/collected_cookies_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/gtk/constrained_html_delegate_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/content_setting_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/download_started_animation_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_installed_bubble_gtk.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/gtk/extension_popup_gtk.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/gtk/infobar_container_gtk.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/general_page_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/options_window_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/reload_button_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/importer/importer.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/modal_html_dialog_delegate.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/repost_form_warning_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/speech/speech_input_bubble_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_change_processor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/options/options_page_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_unpacker.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/url_request_intercept_job.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/nacl/nacl_thread.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
mostly replacing notification_service.h with notification_details.h and/or notification_source.h
10 years ago (2010-12-16 06:49:27 UTC) #1
Elliot Glaysher
10 years ago (2010-12-16 18:19:07 UTC) #2 
On 2010/12/16 06:49:27, Lei Zhang wrote:
> mostly replacing notification_service.h with notification_details.h and/or
> notification_source.h

LGTM

Powered by Google App Engine
This is Rietveld 408576698