Issue 5873005: Views: Implement the ImporterList::Observer in ImporterView to enable the

Issue 5873005: Views: Implement the ImporterList::Observer in ImporterView to enable the (Closed)

Created:
10 years ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Views: Implement the ImporterList::Observer in ImporterView to enable the correct asynchronous version of Importer. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69502

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fixes. #

Patch Set 3 : Line length fix. #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -18 lines)			Patch
M	chrome/browser/importer/importer.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/importer/importer_list.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/importer/importer_list.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/importer_view.h	View		3 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/importer_view.cc	View	1	7 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/5873005/diff/1/chrome/browser/ui/views/importer_view.cc File chrome/browser/ui/views/importer_view.cc (right): http://codereview.chromium.org/5873005/diff/1/chrome/browser/ui/views/importer_view.cc#newcode183 chrome/browser/ui/views/importer_view.cc:183: int item_count; This code should live in SourceProfilesLoaded, and ...

10 years ago (2010-12-16 23:07:22 UTC) #2

James Hawkins

10 years ago (2010-12-16 23:32:13 UTC) #3

LGTM

Expand Messages | Collapse Messages