Remount autodir after reboot.

After reboot, Autotest wasn't remounting the exec capable version; causing a second copy of Autotest to be installed to the mount point.

Change-Id: I9af4d361fd49194706fa916f0ac97eb6686b9f32

BUG=chromium-os:10445
TEST=Running in production. Ran unit-tests.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ac52f54

[ericli, 2010-12-17 04:24:18]

http://codereview.chromium.org/5867003/diff/1/server/autotest.py
File server/autotest.py (right):

http://codereview.chromium.org/5867003/diff/1/server/autotest.py#newcode87
server/autotest.py:87: host.run('mount -o remount,exec ' + autodir)
could you consolidate this logic with _find_installable_dir(). Petty much they
are duplicated.

[DaleCurtis, 2010-12-17 17:46:07]

http://codereview.chromium.org/5867003/diff/1/server/autotest.py
File server/autotest.py (right):

http://codereview.chromium.org/5867003/diff/1/server/autotest.py#newcode87
server/autotest.py:87: host.run('mount -o remount,exec ' + autodir)
I can do this, but I'll have to add a new @classmethod. I know you'd previously
had reservations about this.

Additionally since this method is called so frequently, I'll have to unify both
methods to preserve the existing mount rather than unmounting and remounting if
it exists.

On 2010/12/17 04:24:18, ericli wrote:
> could you consolidate this logic with _find_installable_dir(). Petty much they
> are duplicated.

[ericli, 2010-12-17 18:02:47]

LGTM.

http://codereview.chromium.org/5867003/diff/1/server/autotest.py
File server/autotest.py (right):

http://codereview.chromium.org/5867003/diff/1/server/autotest.py#newcode87
server/autotest.py:87: host.run('mount -o remount,exec ' + autodir)
I see, I also recalled _find_installable_dir() worked on an list of candidate
paths. I dont like that either, but seems more close to upstream design.

On 2010/12/17 17:46:07, dalec wrote:
> I can do this, but I'll have to add a new @classmethod. I know you'd
previously
> had reservations about this.
> 
> Additionally since this method is called so frequently, I'll have to unify
both
> methods to preserve the existing mount rather than unmounting and remounting
if
> it exists.
> 
> On 2010/12/17 04:24:18, ericli wrote:
> > could you consolidate this logic with _find_installable_dir(). Petty much
they
> > are duplicated.
>