Issue 5861008: DevTools: Network requests are timed with 1.6 days.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5861008: DevTools: Network requests are timed with 1.6 days. (Closed)

Created:
10 years ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
tonyg, ericroman, yurys

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, James Simonsen

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DevTools: Network requests are timed with 1.6 days. BUG=65506 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69524

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/browser/net/load_timing_observer.cc	View		1 chunk	+7 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tonyg

10 years ago (2010-12-16 22:21:03 UTC) #2

LGTM

Nice find.

simonjam and I were just noticing some weirdness w/ the navigation timing
numbers, but they didn't show the symptoms as obviously as the inspector because
there is some code in the PerformanceTiming getters that clips them into a known
range.

http://codereview.chromium.org/5861008/diff/1/chrome/browser/net/load_timing_...
File chrome/browser/net/load_timing_observer.cc (right):

http://codereview.chromium.org/5861008/diff/1/chrome/browser/net/load_timing_...
chrome/browser/net/load_timing_observer.cc:24: const int64 kSyncPeriod = 1000 *
1000 * 10;
I'd recommend adding the units to the name: kSyncPeriodMicroseconds.

Expand Messages | Collapse Messages