src/objects.cc - Issue 5861006: Change Object.defineProperty to accept undefined as getters and setters and t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 5861006: Change Object.defineProperty to accept undefined as getters and setters and t... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

===================================================================

--- src/objects.cc (revision 6011)

+++ src/objects.cc (working copy)

@@ -3097,8 +3097,9 @@

MaybeObject* JSObject::DefineAccessor(String* name,

bool is_getter,

- JSFunction* fun,

+ Object* fun,

PropertyAttributes attributes) {

+ ASSERT(fun->IsJSFunction() || fun->IsUndefined());

// Check access rights if needed.

if (IsAccessCheckNeeded() &&

!Top::MayNamedAccess(this, name, v8::ACCESS_SET)) {

« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | src/runtime.cc » ('J')