src/v8natives.js - Issue 5861006: Change Object.defineProperty to accept undefined as getters and setters and t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 5861006: Change Object.defineProperty to accept undefined as getters and setters and t... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

===================================================================

--- src/v8natives.js (revision 6043)

+++ src/v8natives.js (working copy)

@@ -563,7 +563,7 @@

}

// Step 7

- if (desc.isConfigurable() || desc.isEnumerable() != current.isEnumerable())

+ if (desc.isConfigurable() || desc.isEnumerable() != current.isEnumerable())

throw MakeTypeError("redefine_disallowed", ["defineProperty"]);

// Step 9

if (IsDataDescriptor(current) != IsDataDescriptor(desc))

@@ -623,10 +623,12 @@

}

%DefineOrRedefineDataProperty(obj, p, value, flag);

} else {

- if (desc.hasGetter() && IS_FUNCTION(desc.getGet())) {

+ if (desc.hasGetter() &&

+ (IS_FUNCTION(desc.getGet()) || IS_UNDEFINED(desc.getGet()))) {

%DefineOrRedefineAccessorProperty(obj, p, GETTER, desc.getGet(), flag);

}

- if (desc.hasSetter() && IS_FUNCTION(desc.getSet())) {

+ if (desc.hasSetter() &&

+ (IS_FUNCTION(desc.getSet()) || IS_UNDEFINED(desc.getSet()))) {

%DefineOrRedefineAccessorProperty(obj, p, SETTER, desc.getSet(), flag);

}

« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/object-define-property.js » ('j') | no next file with comments »