Change Object.defineProperty to accept undefined as getters and setters and t...

test/mjsunit/object-define-property.js

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 56 matching lines @@
 function setter2() {val2++; }
 function getter2() {return val2; }
 
 function setter3() {val3++; }
 function getter3() {return val3; }
 
 
 // Descriptors.
 var emptyDesc = {};
 
-var accessorConfigurable = { 
+var accessorConfigurable = {
     set: setter1,
     get: getter1,
     configurable: true
 };
 
 var accessorNoConfigurable = {
     set: setter2,
     get: getter2,
-    configurable: false 
+    configurable: false
 };
 
 var accessorOnlySet = {
   set: setter3,
   configurable: true
 };
 
 var accessorOnlyGet = {
   get: getter3,
   configurable: true
@@ skipping 130 matching lines @@
 desc = Object.getOwnPropertyDescriptor(obj1, "setOnly");
 assertTrue(desc.configurable);
 assertFalse(desc.enumerable);
 assertEquals(desc.get, accessorOnlyGet.get);
 assertEquals(desc.set, accessorOnlySet.set);
 assertEquals(desc.writable, undefined);
 assertEquals(desc.value, undefined);
 assertEquals(1, obj1.setOnly = 1);
 assertEquals(2, val3);
 
-// The above should also work if redefining just a getter or setter on 
+// The above should also work if redefining just a getter or setter on
 // an existing property with both a getter and a setter.
 Object.defineProperty(obj1, "both", accessorConfigurable);
 
 Object.defineProperty(obj1, "both", accessorOnlySet);
 desc = Object.getOwnPropertyDescriptor(obj1, "both");
 assertTrue(desc.configurable);
 assertFalse(desc.enumerable);
 assertEquals(desc.set, accessorOnlySet.set);
 assertEquals(desc.get, accessorConfigurable.get);
 assertEquals(desc.writable, undefined);
@@ skipping 129 matching lines @@
 desc = Object.getOwnPropertyDescriptor(obj2, "bar");
 assertEquals(obj2.bar, 1000);
 assertEquals(desc.value, 1000);
 assertTrue(desc.configurable);
 assertFalse(desc.writable);
 assertFalse(desc.enumerable);
 assertEquals(desc.get, undefined);
 assertEquals(desc.set, undefined);
 
 
-// Redefinition of an accessor defined using __defineGetter__ and 
+// Redefinition of an accessor defined using __defineGetter__ and
 // __defineSetter__.
 function get(){return this.x}
 function set(x){this.x=x};
 
 var obj3 = {x:1000};
 obj3.__defineGetter__("foo", get);
 obj3.__defineSetter__("foo", set);
 
 desc = Object.getOwnPropertyDescriptor(obj3, "foo");
 assertTrue(desc.configurable);
@@ skipping 57 matching lines @@
 // Make sure an error is thrown when trying to access to redefined function.
 try {
   obj4.bar();
   assertTrue(false);
 } catch (e) {
   assertTrue(/is not a function/.test(e));
 }
 
 
 // Test runtime calls to DefineOrRedefineDataProperty and
-// DefineOrRedefineAccessorProperty - make sure we don't 
+// DefineOrRedefineAccessorProperty - make sure we don't
 // crash.
 try {
   %DefineOrRedefineAccessorProperty(0, 0, 0, 0, 0);
 } catch (e) {
   assertTrue(/illegal access/.test(e));
 }
 
 try {
   %DefineOrRedefineDataProperty(0, 0, 0, 0);
 } catch (e) {
@@ skipping 28 matching lines @@
 
 try {
   %DefineOrRedefineDataProperty(null, 'foo', 0, 0);
 } catch (e) {
   assertTrue(/illegal access/.test(e));
 }
 
 // Test that all possible differences in step 6 in DefineOwnProperty are
 // exercised, i.e., any difference in the given property descriptor and the
 // existing properties should not return true, but throw an error if the
-// existing configurable property is false. 
+// existing configurable property is false.
 
 var obj5 = {};
 // Enumerable will default to false.
 Object.defineProperty(obj5, 'foo', accessorNoConfigurable);
 desc = Object.getOwnPropertyDescriptor(obj5, 'foo');
 // First, test that we are actually allowed to set the accessor if all
 // values are of the descriptor are the same as the existing one.
 Object.defineProperty(obj5, 'foo', accessorNoConfigurable);
 
 // Different setter.
@@ skipping 195 matching lines @@
 obj6[1] = 'foo';
 obj6[2] = 'bar';
 obj6[3] = '42';
 obj6[4] = '43';
 obj6[5] = '44';
 
 var descElement = { value: 'foobar' };
 var descElementNonConfigurable = { value: 'barfoo', configurable: false };
 var descElementNonWritable = { value: 'foofoo', writable: false };
 var descElementNonEnumerable = { value: 'barbar', enumerable: false };
-var descElementAllFalse = { value: 'foofalse', 
+var descElementAllFalse = { value: 'foofalse',
                             configurable: false,
                             writable: false,
                             enumerable: false };
 
 
 // Redefine existing property.
 Object.defineProperty(obj6, '1', descElement);
 desc = Object.getOwnPropertyDescriptor(obj6, '1');
 assertEquals(desc.value, 'foobar');
 assertTrue(desc.writable);
@@ skipping 42 matching lines @@
 // Define non existing property - all attributes should default to false.
 Object.defineProperty(obj6, '15', descElement);
 desc = Object.getOwnPropertyDescriptor(obj6, '15');
 assertEquals(desc.value, 'foobar');
 assertFalse(desc.writable);
 assertFalse(desc.enumerable);
 assertFalse(desc.configurable);
 
 // Make sure that we can't redefine using direct access.
 obj6[15] ='overwrite';
-assertEquals(obj6[15],'foobar'); 
+assertEquals(obj6[15],'foobar');
 
 
 // Repeat the above tests on an array.
 var arr = new Array();
 arr[1] = 'foo';
 arr[2] = 'bar';
 arr[3] = '42';
 arr[4] = '43';
 arr[5] = '44';
 
 var descElement = { value: 'foobar' };
 var descElementNonConfigurable = { value: 'barfoo', configurable: false };
 var descElementNonWritable = { value: 'foofoo', writable: false };
 var descElementNonEnumerable = { value: 'barbar', enumerable: false };
-var descElementAllFalse = { value: 'foofalse', 
+var descElementAllFalse = { value: 'foofalse',
                             configurable: false,
                             writable: false,
                             enumerable: false };
 
 
 // Redefine existing property.
 Object.defineProperty(arr, '1', descElement);
 desc = Object.getOwnPropertyDescriptor(arr, '1');
 assertEquals(desc.value, 'foobar');
 assertTrue(desc.writable);
@@ skipping 72 matching lines @@
 assertEquals(undefined, o.x);
 o.x = 37;
 assertEquals(undefined, o.x);
 
 // Ignore inherited properties.
 o = { __proto__ : { x : 87 } };
 Object.defineProperty(o, "x", { writable: false });
 assertEquals(undefined, o.x);
 o.x = 37;
 assertEquals(undefined, o.x);
-