Issue 5861003: Fix search_engines tests to use localhost:1000 instead of localhost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5861003: Fix search_engines tests to use localhost:1000 instead of localhost (Closed)

Created:
10 years ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
Allen

CC:
chromium-reviews, John Grabowski, anantha, dyu1, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix search_engines tests to use localhost:1000 instead of localhost Turns out that the bot might be running an http server which can lead to redirects and mess up the test. Use a url at a port which is unlikely to be active. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69317

Patch Set 1 #

Patch Set 2 : ace #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	chrome/test/functional/search_engines.py	View	1	5 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Allen

lgtm should we set this address string somewhere like pyauto.py or at the top of ...

10 years ago (2010-12-15 20:43:38 UTC) #2

Nirnimesh

10 years ago (2010-12-15 21:20:04 UTC) #3

On 2010/12/15 20:43:38, Allen wrote:
> lgtm
> 
> should we set this address string somewhere like pyauto.py or at the top of
this
> file as a constant since it comes up in multiple test cases (and may in the
> future)?

Good idea. Done.

Expand Messages | Collapse Messages