Issue 586002: Added helper functions for fixed register allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 586002: Added helper functions for fixed register allocation. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Added helper functions for fixed register allocation. Added helper functions to the fast code generator for temporary, ad hoc fixed register allocation. Also inlined some helper functions that had only one call site to simplify the code generator API for now. Committed: http://code.google.com/p/v8/source/detail?r=3818

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -140 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View	3 chunks	+47 lines, -46 lines	0 comments	Download
M	src/fast-codegen.h	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/ia32/fast-codegen-ia32.cc	View	3 chunks	+49 lines, -46 lines	1 comment	Download
M	src/x64/fast-codegen-x64.cc	View	3 chunks	+51 lines, -46 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years, 10 months ago (2010-02-09 09:38:32 UTC) #2

LGTM.

http://codereview.chromium.org/586002/diff/1/4
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/586002/diff/1/4#newcode87
src/ia32/fast-codegen-ia32.cc:87: __ mov(accumulator1(), accumulator0());
As a separate change: Would it make sense to have a write barrier that does not
need the value on IA32 and x64?
This would make the interface uniform across the platforms.

Expand Messages | Collapse Messages