Issue 5860009: Fix bugs in the range analysis for integers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5860009: Fix bugs in the range analysis for integers.... (Closed)

Created:
10 years ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bugs in the range analysis for integers. The overflow conditions were not correctly detected for certain add, sub and mul instructions. I replaced the previous code by using 64-bit arithmetic to correctly identify overflows for *, + and -. Committed: http://code.google.com/p/v8/source/detail?r=6055

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -75 lines)			Patch
M	src/hydrogen.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	2 chunks	+4 lines, -1 line	1 comment	Download
M	src/hydrogen-instructions.cc	View	1	3 chunks	+29 lines, -72 lines	0 comments	Download
A	test/mjsunit/compiler/regress-intoverflow.js	View		1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years ago (2010-12-16 17:48:09 UTC) #2

LGTM

http://codereview.chromium.org/5860009/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/5860009/diff/5001/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:337: void AddConstant(int32_t value);
Comment what this function does to this Range.

Expand Messages | Collapse Messages