Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5860008: Enable client-based geolocation. (Closed)

Created:
10 years ago by John Knottenbelt
Modified:
9 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Enable client-based geolocation. BUG=59907 TEST=BrowserTest:Geolocation*, LayoutTests:fast/dom/Geolocation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69545 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70340

Patch Set 1 #

Patch Set 2 : Fix accidental double -> int64 -> double conversion. #

Patch Set 3 : Disable GeolocationPermissionContextTests.StopUpdating #

Patch Set 4 : Moved fixes into a separate issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/features_override.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
John Knottenbelt
Enable client-based geolocation.
10 years ago (2010-12-17 14:35:19 UTC) #1
bulach
10 years ago (2010-12-17 14:36:50 UTC) #2 
LGTM

thanks for flipping the bit!

Powered by Google App Engine
This is Rietveld 408576698