chrome/browser/chromeos/audio_mixer.cc - Issue 5859003: Add ALSA support to volume keys

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/audio_mixer.cc

Issue 5859003: Add ALSA support to volume keys (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos

Patch Set: more cleanup Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/chromeos/audio_mixer.h"

	6

	7 namespace chromeos {

	8

	9 AudioMixer::AudioMixer() {
	Daniel Erat 2011/01/05 01:06:53 Any reason that these can't just go in the header? Any reason that these can't just go in the header? davejcool 2011/01/05 01:42:16 I moved them into a .cc after Andrew's comment to: Show quoted text On 2011/01/05 01:06:53, Daniel Erat wrote: > Any reason that these can't just go in the header? I moved them into a .cc after Andrew's comment to: "avoid inlining virtual methods (i.e., put these in a .cc)". The destructor is virtual, so perhaps empty virtual functions would be an exception?
	10 }

	11

	12 AudioMixer::~AudioMixer() {

	13 }

	14

	15 } // namespace chromeos

	16

OLD	NEW