Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 5859002: Fixed update_kernel.sh not to put an extra set of quotes w/ enter_chroot. (Closed)

Created:
10 years ago by diandersAtChromium
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fixed update_kernel.sh not to put an extra set of quotes w/ enter_chroot. This change is in preparation for the new sudo, which corrects how parameters are passed to subcommands. Change-Id: I34d09d2716fbef137d02748a2934459a8a10d693 BUG=chromium-os:7072 TEST=Ran modified "update_kernel.sh" w/ old sudo and new sudo. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ebe1baa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M update_kernel.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
diandersAtChromium
Mandeep, This is needed for the sudo update, which I'm trying to push through ASAP ...
10 years ago (2010-12-15 21:27:37 UTC) #1
Mandeep Singh Baines
10 years ago (2010-12-15 21:37:31 UTC) #2
LGTM. Thanks!

dianders@chromium.org (dianders@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines, davidjames,
> 
> Message:
> Mandeep,
> 
> This is needed for the sudo update, which I'm trying to push through
> ASAP (it
> fixes argument quoting, which people need).
> 
> Thanks!
> 
> Description:
> Fixed update_kernel.sh not to put an extra set of quotes w/ enter_chroot.
> 
> This change is in preparation for the new sudo, which corrects how
> parameters are passed to subcommands.
> 
> Change-Id: I34d09d2716fbef137d02748a2934459a8a10d693
> 
> BUG=chromium-os:7072
> TEST=Ran modified "update_kernel.sh" w/ old sudo and new sudo.
> 
> Please review this at http://codereview.chromium.org/5859002/
> 
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
> 
> Affected files:
>   M update_kernel.sh
> 
> 
> Index: update_kernel.sh
> diff --git a/update_kernel.sh b/update_kernel.sh
> index
126786b2f66c97198b60b9e66c1e6e4fb27f218c..4166709aea65be6fabd654f08f1bdbfeca25635e
> 100755
> --- a/update_kernel.sh
> +++ b/update_kernel.sh
> @@ -66,7 +66,7 @@ function main() {
>         --bootloader /lib64/bootstub/bootstub.efi \
>         --vmlinuz /build/${FLAGS_board}/boot/vmlinuz"
> 
> -  ./enter_chroot.sh -- "${cmd}"
> +  ./enter_chroot.sh -- ${cmd}
> 
>    learn_partition
> 
> 
> 

Powered by Google App Engine
This is Rietveld 408576698