Issue 5858004: Clean-up BackgroundModeManager-BackgroundApplicationListModel interaction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5858004: Clean-up BackgroundModeManager-BackgroundApplicationListModel interaction (Closed)

Created:
10 years ago by The wrong rickcam account

Modified:
9 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Cleaning up some issues discovered in a semi-related code review. BUG=67206 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69778

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/background_mode_manager.cc	View		1 chunk	+4 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

http://codereview.chromium.org/5858004/diff/1/chrome/browser/background_mode_manager.cc File chrome/browser/background_mode_manager.cc (right): http://codereview.chromium.org/5858004/diff/1/chrome/browser/background_mode_manager.cc#newcode288 chrome/browser/background_mode_manager.cc:288: menu->AddItem(position, UTF8ToUTF16(name)); LGTM.

10 years ago (2010-12-17 01:56:22 UTC) #1

LGTM

Expand Messages | Collapse Messages