Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5455)

Unified Diff: chrome/renderer/render_view.cc

Issue 5857007: Unify strings for click-to-play, blocked plugins and outdated plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/renderer/resources
Patch Set: change crosshair to pointer Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/renderer/renderer_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index de224b27f7ae85657fd35a580be4127a4b252f8f..f1b6818c24c8d9f3523709ec5b8a6dd9b6547232 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -2772,7 +2772,7 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
return CreatePluginPlaceholder(frame,
params,
*group,
- IDR_OUTDATED_PLUGIN_HTML,
+ IDR_BLOCKED_PLUGIN_HTML,
IDS_PLUGIN_OUTDATED);
}
if (!info.enabled)
@@ -2797,13 +2797,13 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
return CreatePluginPlaceholder(frame,
params,
*group,
- IDR_BLOCKED_PLUGIN_HTML,
+ IDR_CLICK_TO_PLAY_PLUGIN_HTML,
IDS_PLUGIN_LOAD);
} else {
return CreatePluginPlaceholder(frame,
params,
*group,
- IDR_OUTDATED_PLUGIN_HTML,
+ IDR_BLOCKED_PLUGIN_HTML,
IDS_PLUGIN_BLOCKED);
}
}
@@ -4452,7 +4452,8 @@ WebPlugin* RenderView::CreatePluginPlaceholder(
params,
webkit_preferences_,
resource_id,
- l10n_util::GetStringUTF16(message_id));
+ l10n_util::GetStringFUTF16(message_id,
+ group.GetGroupName()));
return blocked_plugin->plugin();
}
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/renderer/renderer_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698