no native implementation of Textfield.

views/controls/textfield/textfield.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 25 matching lines @@
 // This class implements a ChromeView that wraps a native text (edit) field.
 class Textfield : public View {
  public:
   // The button's class name.
   static const char kViewClassName[];
 
   // Keystroke provides a platform-dependent way to send keystroke events.
   // Cross-platform code can use IsKeystrokeEnter/Escape to check for these
   // two common key events.
   // TODO(brettw) this should be cleaned up to be more cross-platform.
   class Keystroke {

[oshima, 2010/12/15 17:29:06]

I wonder if we need this now. Is it possible to replace this with KeyEvent?

    public:
 #if defined(OS_WIN)
     const Keystroke(unsigned int m,
               wchar_t k,
               int r,
               unsigned int f)
         : message_(m),
           key_(k),
           repeat_count_(r),
           flags_(f) {
     }
     unsigned int message() const { return message_; }
     wchar_t key() const { return key_; }
     int repeat_count() const { return repeat_count_; }
     unsigned int flags() const { return flags_; }
 #else
-    explicit Keystroke(GdkEventKey* event)
-        : event_(*event) {
+    explicit Keystroke(const KeyEvent* event)
+        : event_(event) {
     }

[oshima, 2010/12/15 17:29:06]

This seems to be safe as Keystroke is used on stack and the lifetime of
keystroke is shorter than keyevent. Please let me know if I should copy the
event.

-    const GdkEventKey* event() const { return &event_; }
+    const GdkEventKey* event() const { return event_->native_event(); }

[rjkroege, 2010/12/15 21:23:31]

I think we should exclude this in a touchui=1 context yes?

[oshima, 2010/12/16 01:15:19]

we still need this to compile.

 #endif
     app::KeyboardCode GetKeyboardCode() const;
     bool IsControlHeld() const;
     bool IsShiftHeld() const;
 
    private:
 #if defined(OS_WIN)
     unsigned int message_;
     wchar_t key_;
     int repeat_count_;
     unsigned int flags_;
 #else
-    GdkEventKey event_;
+    const KeyEvent* event_;
 #endif
 
     DISALLOW_COPY_AND_ASSIGN(Keystroke);
   };
 
   // This defines the callback interface for other code to be notified of
   // changes in the state of a text field.
   class Controller {
    public:
     // This method is called whenever the text in the field changes.
@@ skipping 133 matching lines @@
   // been deleted during a window close.
   void SyncText();
 
   // Returns whether or not an IME is composing text.
   bool IsIMEComposing() const;
 
 #ifdef UNIT_TEST
   gfx::NativeView GetTestingHandle() const {
     return native_wrapper_ ? native_wrapper_->GetTestingHandle() : NULL;
   }
+  NativeTextfieldWrapper* native_wrapper() const {
+    return native_wrapper_;
+  }
 #endif
 
   // Overridden from View:
   virtual void Layout();
   virtual gfx::Size GetPreferredSize();
   virtual bool IsFocusable() const;
   virtual void AboutToRequestFocusFromTabTraversal(bool reverse);
   virtual bool SkipDefaultKeyEventProcessing(const KeyEvent& e);
   virtual void SetEnabled(bool enabled);
   virtual void PaintFocusBorder(gfx::Canvas* canvas);
@@ skipping 68 matching lines @@
 
   // Text to display when empty.
   string16 text_to_display_when_empty_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_