Cleanup: USE_X11 + OS_MACOSX = OS_POSIX.

Cleanup: USE_X11 + OS_MACOSX = OS_POSIX.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69854

[Lei Zhang, 2010-12-15 02:07:12]

USE_X11 + OS_MACOSX = OS_POSIX
OS_POSIX - OS_MACOSX = USE_X11

[evanm, 2010-12-15 02:12:53]

LGTM with some suggestions

http://codereview.chromium.org/5856001/diff/1/chrome/browser/browser_focus_ui...
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/5856001/diff/1/chrome/browser/browser_focus_ui...
chrome/browser/browser_focus_uitest.cc:7: #if defined(OS_WIN)
I think Brett concluded we should put all these below the block of headers, like
how it was before.

http://codereview.chromium.org/5856001/diff/1/chrome/browser/process_singleton.h
File chrome/browser/process_singleton.h (right):

http://codereview.chromium.org/5856001/diff/1/chrome/browser/process_singleto...
chrome/browser/process_singleton.h:70: #if defined(USE_X11)
Is this really an X11-specific block of code?
Consider e.g. a future version of ChromeOS that doesn't use X.

http://codereview.chromium.org/5856001/diff/1/gfx/native_widget_types.h
File gfx/native_widget_types.h (right):

http://codereview.chromium.org/5856001/diff/1/gfx/native_widget_types.h#newco...
gfx/native_widget_types.h:123: #elif defined(OS_POSIX)
This could just as well be "else".  Only on Windows are HWNDs global.

[Lei Zhang, 2010-12-21 05:14:42]

http://codereview.chromium.org/5856001/diff/1/chrome/browser/browser_focus_ui...
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/5856001/diff/1/chrome/browser/browser_focus_ui...
chrome/browser/browser_focus_uitest.cc:7: #if defined(OS_WIN)
On 2010/12/15 02:12:53, evanm wrote:
> I think Brett concluded we should put all these below the block of headers,
like
> how it was before.

Ok, reverted.

http://codereview.chromium.org/5856001/diff/1/chrome/browser/process_singleton.h
File chrome/browser/process_singleton.h (right):

http://codereview.chromium.org/5856001/diff/1/chrome/browser/process_singleto...
chrome/browser/process_singleton.h:70: #if defined(USE_X11)
On 2010/12/15 02:12:53, evanm wrote:
> Is this really an X11-specific block of code?
> Consider e.g. a future version of ChromeOS that doesn't use X.

Changed this to OS_LINUX since it's only implemented in
process_singleton_linux.cc.

[Evan Martin, 2010-12-21 05:15:46]

LGTM

http://codereview.chromium.org/5856001/diff/11001/chrome/browser/printing/pri...
File chrome/browser/printing/print_job_worker.cc (right):

http://codereview.chromium.org/5856001/diff/11001/chrome/browser/printing/pri...
chrome/browser/printing/print_job_worker.cc:98: NewCallback(this,
&PrintJobWorker::GetSettingsDone));
I wish this stuff could be unified...

[Lei Zhang, 2010-12-21 05:39:23]

http://codereview.chromium.org/5856001/diff/11001/chrome/browser/printing/pri...
File chrome/browser/printing/print_job_worker.cc (right):

http://codereview.chromium.org/5856001/diff/11001/chrome/browser/printing/pri...
chrome/browser/printing/print_job_worker.cc:98: NewCallback(this,
&PrintJobWorker::GetSettingsDone));
On 2010/12/21 05:15:46, Evan Martin wrote:
> I wish this stuff could be unified...

We can probably get rid of the Windows-only path, but in another CL...