Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5854003: Remove CrOS hack from ppapi.gyp that made the include directories work. This... (Closed)

Created:
10 years ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, nkostylev+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove CrOS hack from ppapi.gyp that made the include directories work. This fixes the includes for cros to use "third_party" so that everything works. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69493

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -54 lines) Patch
M chrome/browser/DEPS View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/brightness_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/burn_library.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_library_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cros_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cryptohome_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/input_method_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/keyboard_library.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/keyboard_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/login_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/mock_mount_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/mount_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/power_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/screen_lock_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/speech_synthesis_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/syslogs_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/system_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/touchpad_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/update_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dom_ui/language_customize_modifier_keys_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/bubble_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/panel_browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/google_update_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth_attempt_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/test_attempt_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/notification_panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_config_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/panels/panel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/views/domui_menu_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/wm_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/wm_overview_fav_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/wm_overview_title.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/info_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi.gyp View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
10 years ago (2010-12-16 20:44:59 UTC) #1
DaveMoore
10 years ago (2010-12-16 22:20:47 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698