Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 585004: Move class declaration of Comment from codegen-inl.h to codegen.h... (Closed)

Created:
10 years, 10 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move class declaration of Comment from codegen-inl.h to codegen.h -inl.h files should only contains small inline functions and no class declarations. Implementation moved to codegen.cc since it's not a performance critical class (only used in DEBUG mode). Committed: http://code.google.com/p/v8/source/detail?r=3812

Patch Set 1 #

Total comments: 2

Patch Set 2 : v2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M src/codegen.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/codegen-inl.h View 1 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
A small review for you. I'm breaking up my large changelist for cleaning up header ...
10 years, 10 months ago (2010-02-07 14:50:49 UTC) #1
Kevin Millikin (Chromium)
LGTM. http://codereview.chromium.org/585004/diff/1/3 File src/codegen.h (right): http://codereview.chromium.org/585004/diff/1/3#newcode100 src/codegen.h:100: // ----------------------------------------------------------------------------- I don't find these lines very ...
10 years, 10 months ago (2010-02-08 08:45:37 UTC) #2
fschneider
10 years, 10 months ago (2010-02-08 08:53:13 UTC) #3
http://codereview.chromium.org/585004/diff/1/3
File src/codegen.h (right):

http://codereview.chromium.org/585004/diff/1/3#newcode100
src/codegen.h:100: //
-----------------------------------------------------------------------------
On 2010/02/08 08:45:37, Kevin Millikin wrote:
> I don't find these lines very helpful.  I'm happy if you delete it.

Done.

Powered by Google App Engine
This is Rietveld 408576698