Move GUID utils to src/chrome/common.

Move GUID utils to src/chrome/common.

BUG=None
TEST=compiles,unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69347

[Sergey Ulanov, 2010-12-15 01:02:40]

I will need to use guid.h in chrome/service for remoting.

[Ilya Sherman, 2010-12-15 01:37:52]

http://codereview.chromium.org/5849001/diff/10001/base/guid.h
File base/guid.h (right):

http://codereview.chromium.org/5849001/diff/10001/base/guid.h#newcode30
base/guid.h:30: }  // namespace guid
nit: // namespace base

[Sergey Ulanov, 2010-12-15 01:45:05]

http://codereview.chromium.org/5849001/diff/10001/base/guid.h
File base/guid.h (right):

http://codereview.chromium.org/5849001/diff/10001/base/guid.h#newcode30
base/guid.h:30: }  // namespace guid
On 2010/12/15 01:37:52, Ilya Sherman wrote:
> nit: // namespace base

Done.

[dhollowa, 2010-12-15 01:55:36]

My prediction is that Brett will favor chrome/common/guid*.

[brettw, 2010-12-15 07:30:38]

Indeed! Any time you want to add anything in base, please list any alternate
places you considered and why they can't work or are inappropriate. In this
case, I can think of at least chrome/common and app/win as other locations you
might consider.

[Ilya Sherman, 2010-12-15 07:34:49]

On 2010/12/15 07:30:38, brettw wrote:
> In this case, I can think of at least chrome/common and app/win
> as other locations you might consider.

Probably not app/win, since these guids are not Windows-only ;)

[Sergey Ulanov, 2010-12-15 21:24:52]

On 2010/12/15 07:30:38, brettw wrote:
> Indeed! Any time you want to add anything in base, please list any alternate
> places you considered and why they can't work or are inappropriate. In this
> case, I can think of at least chrome/common and app/win as other locations you
> might consider.

app/win doesn't work because this code is used on all three platforms.
chrome/common works now, but it future we may need to use this code in
src/remoting, or separate service process  from chrome, and so we would need to
move guid out of chrome/common anyway. Besides, UUIDs is very basic concept,
that may be needed in other places outside of src/chrome in the future, so
src/base seems to be the right place for this code.

[brettw, 2010-12-15 21:36:56]

On Wed, Dec 15, 2010 at 1:24 PM,  <sergeyu@chromium.org> wrote:
> On 2010/12/15 07:30:38, brettw wrote:
>>
>> Indeed! Any time you want to add anything in base, please list any
>> alternate
>> places you considered and why they can't work or are inappropriate. In
>> this
>> case, I can think of at least chrome/common and app/win as other locations
>> you
>> might consider.
>
> app/win doesn't work because this code is used on all three platforms.
> chrome/common works now, but it future we may need to use this code in
> src/remoting, or separate service process  from chrome, and so we would need
> to
> move guid out of chrome/common anyway. Besides, UUIDs is very basic concept,
> that may be needed in other places outside of src/chrome in the future, so
> src/base seems to be the right place for this code.

We can make that argument for almost anything in chrome/common. If
this is really needed elsewhere, we can always move it later.

Brett

[Sergey Ulanov, 2010-12-15 22:27:32]

On 2010/12/15 21:36:56, brettw wrote:
> On Wed, Dec 15, 2010 at 1:24 PM,  <mailto:sergeyu@chromium.org> wrote:
> > On 2010/12/15 07:30:38, brettw wrote:
> >>
> >> Indeed! Any time you want to add anything in base, please list any
> >> alternate
> >> places you considered and why they can't work or are inappropriate. In
> >> this
> >> case, I can think of at least chrome/common and app/win as other locations
> >> you
> >> might consider.
> >
> > app/win doesn't work because this code is used on all three platforms.
> > chrome/common works now, but it future we may need to use this code in
> > src/remoting, or separate service process &nbsp;from chrome, and so we would
need
> > to
> > move guid out of chrome/common anyway. Besides, UUIDs is very basic concept,
> > that may be needed in other places outside of src/chrome in the future, so
> > src/base seems to be the right place for this code.
> 
> We can make that argument for almost anything in chrome/common. If
> this is really needed elsewhere, we can always move it later.
> 
> Brett

Ok. Moved it to chrome/common

[dhollowa, 2010-12-15 22:36:45]

LGTM.

[brettw, 2010-12-15 22:37:53]

Thanks! (I'm assuming you don't need a detailed review from me).