chrome/browser/enumerate_modules_model_win.cc - Issue 5848005: base/version: remove wstring version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 5848005: base/version: remove wstring version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: retry Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/enumerate_modules_model_win.cc

diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc

index 9de5c763047855f60a81971d4244a10ec86ce82a..83dc5358b8ae0f88aecbcfd6406e83904a3583ca 100644

--- a/chrome/browser/enumerate_modules_model_win.cc

+++ b/chrome/browser/enumerate_modules_model_win.cc

@@ -266,7 +266,7 @@ ModuleEnumerator::ModuleStatus ModuleEnumerator::Match(

// We have a name match against the blacklist (and possibly location match

// also), so check version.

scoped_ptr<Version> module_version(

- Version::GetVersionFromString(module.version));

+ Version::GetVersionFromString(UTF16ToASCII(module.version)));

scoped_ptr<Version> version_min(

Version::GetVersionFromString(blacklisted.version_from));

scoped_ptr<Version> version_max(