Issue 5846005: Simplify and clearify push logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5846005: Simplify and clearify push logic. (Closed)

Created:
10 years ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
scottz

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Simplify and clearify push logic. Change-Id: I5366fb930ca76f596f49d0312228aa5beeccbc31 BUG=chromium-os:8693 TEST=Ran it with and without dryrun and chrome uprev. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e516dae

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cros_mark_as_stable.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

sosa

10 years ago (2010-12-17 04:06:28 UTC) #3

Thanks for the quick reviews!!

On Thu, Dec 16, 2010 at 8:01 PM,  <scottz@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/5846005/
>