Issue 5846001: Making CUPS calls non-blocking....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5846001: Making CUPS calls non-blocking.... (Closed)

Created:
10 years ago by gene

Modified:
9 years, 6 months ago

Reviewers:
sanjeevr, gene1

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Making CUPS calls non-blocking. BUG=none TEST=Verify proxy is not blocked on CUPS calls. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69357

Patch Set 5 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
M	chrome/service/cloud_print/print_system_cups.cc	View	1 2	4 chunks	+7 lines, -2 lines	0 comments	Download
M	printing/backend/print_backend_consts.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	printing/backend/print_backend_consts.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	printing/backend/print_backend_cups.cc	View	1 2 3 4	6 chunks	+12 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sanjeevr

http://codereview.chromium.org/5846001/diff/4001/printing/backend/print_backend_cups.cc File printing/backend/print_backend_cups.cc (right): http://codereview.chromium.org/5846001/diff/4001/printing/backend/print_backend_cups.cc#newcode211 printing/backend/print_backend_cups.cc:211: http.SetBlocking(false); Since this is a generic helper, perhaps pass ...

10 years ago (2010-12-15 23:06:30 UTC) #2

gene1

Done. Could you please take a look. On Wed, Dec 15, 2010 at 3:06 PM, ...

10 years ago (2010-12-16 00:04:04 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 5846001: Making CUPS calls non-blocking.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages