Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 5845002: Attempt to get rid of chrome_frame_perftests dependency on nspr.lib which cau... (Closed)

Created:
10 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Attempt to get rid of chrome_frame_perftests dependency on nspr.lib which causes random build errors. TBR=amit BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/chrome_frame.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years ago (2010-12-15 00:54:17 UTC) #1
amit
10 years ago (2010-12-15 18:25:40 UTC) #2
lgtm. Remove Delayload for nspr4?

On Tue, Dec 14, 2010 at 4:54 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Attempt to get rid of chrome_frame_perftests dependency on nspr.lib which
> causes
> random build
> errors.
>
> TBR=amit
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/5845002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_frame.gyp
>
>
> Index: chrome_frame/chrome_frame.gyp
> ===================================================================
> --- chrome_frame/chrome_frame.gyp       (revision 69103)
> +++ chrome_frame/chrome_frame.gyp       (working copy)
> @@ -386,7 +386,6 @@
>         'chrome_frame_utils',
>         'chrome_tab_idl',
>         'npchrome_frame',
> -        'xulrunner_sdk',
>       ],
>       'sources': [
>         '../base/perf_test_suite.h',
> @@ -431,6 +430,7 @@
>           },
>           'msvs_settings': {
>             'VCLinkerTool': {
> +              'IgnoreDefaultLibraryNames': ['nspr.lib', 'nspr4.lib'],
>               'DelayLoadDLLs': ['nspr4.dll'],
>             },
>           },
>
>
>

Powered by Google App Engine
This is Rietveld 408576698