Issue 5844001: seccomp: remove build-time flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5844001: seccomp: remove build-time flags (Closed)

Created:
10 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, nkostylev+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., native-client-reviews_googlegroups.com, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

seccomp: remove build-time flags Adjusting seccomp through the .gyp file is error-prone and confusing. Instead, because all callers call SeccompSandboxEnabled(), if I want to enable it for some build configuration I can adjust just that function. This change removes all the build-time seccomp configuration and leaves it defaulted off. It should have no change on whether seccomp is enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69208

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -27 lines)			Patch
M	build/common.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/zygote_host_linux.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	chrome/renderer/renderer_main_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/nacl/nacl_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages