Chroot: allow multiple simultaneous entry.

src/scripts/enter_chroot.sh

 #!/bin/bash
 
 # Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to enter the chroot environment
 
 # Load common constants.  This should be the first executable line.
 # The path to common.sh should be relative to your script's location.
@@ skipping 41 matching lines @@
 if [ $FLAGS_official_build -eq $FLAGS_TRUE ]
 then
    CHROMEOS_OFFICIAL=1
 fi
 
 # Only now can we die on error.  shflags functions leak non-zero error codes,
 # so will die prematurely if 'set -e' is specified before now.
 # TODO: replace shflags with something less error-prone, or contribute a fix.
 set -e
 
+sudo chmod 0777 "$FLAGS_chroot/var/lock"
+
+LOCKFILE="$FLAGS_chroot/var/lock/enter_chroot"
+
 function setup_env {
-  echo "Mounting chroot environment."
+  (
+    flock 200
+    echo $$ >> "$LOCKFILE"
 
-  # Mount only if not already mounted
-  MOUNTED_PATH="$(readlink -f "$FLAGS_chroot/proc")"
-  if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
-  then
-    sudo mount none -t proc "$MOUNTED_PATH"
-  fi
+    echo "Mounting chroot environment."
 
-  MOUNTED_PATH="$(readlink -f "$FLAGS_chroot/dev/pts")"
-  if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
-  then
-    sudo mount none -t devpts "$MOUNTED_PATH"
-  fi
+    # Mount only if not already mounted
+    MOUNTED_PATH="$(readlink -f "$FLAGS_chroot/proc")"
+    if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
+    then
+      sudo mount none -t proc "$MOUNTED_PATH"
+    fi
 
-  MOUNTED_PATH="$(readlink -f "${FLAGS_chroot}$CHROOT_TRUNK_DIR")"
-  if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
-  then
-    sudo mount --bind "$FLAGS_trunk" "$MOUNTED_PATH"
-  fi
+    MOUNTED_PATH="$(readlink -f "$FLAGS_chroot/dev/pts")"
+    if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
+    then
+      sudo mount none -t devpts "$MOUNTED_PATH"
+    fi
+
+    MOUNTED_PATH="$(readlink -f "${FLAGS_chroot}$CHROOT_TRUNK_DIR")"
+    if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
+    then
+      sudo mount --bind "$FLAGS_trunk" "$MOUNTED_PATH"
+    fi
+  ) 200>>"$LOCKFILE"
 }
 
 function teardown_env {
-  echo "Unmounting chroot environment."
-  mount | grep "on $(readlink -f "$FLAGS_chroot")" | awk '{print $3}' \
-    | xargs -r -L1 sudo umount
+  # Only teardown if we're the last enter_chroot to die
+
+  (
+    flock 200
+
+    # check each pid in $LOCKFILE to see if it's died unexpectedly
+    TMP_LOCKFILE="$LOCKFILE.tmp"
+
+    echo -n > "$TMP_LOCKFILE"  # Erase/reset temp file
+    cat "$LOCKFILE" | while read PID; do
+      if [ "$PID" = "$$" ]; then
+        # ourself, leave PROC_NAME empty
+        PROC_NAME=""
+      else
+        PROC_NAME=$(ps --pid $PID -o comm=)
+      fi
+
+      if [ ! -z "$PROC_NAME" ]; then
+        # All good, keep going
+        echo "$PID" >> "$TMP_LOCKFILE"
+      fi
+    done
+    # Remove any dups from lock file while installing new one
+    sort -n "$TMP_LOCKFILE" | uniq > "$LOCKFILE"
+
+    if [ -s "$LOCKFILE" ]; then
+      echo "At least one other pid is running in the chroot, so not"
+      echo "tearing down env."
+    else
+      echo "Unmounting chroot environment."
+      mount | grep "on $(readlink -f "$FLAGS_chroot")" | awk '{print $3}' \
+        | xargs -r -L1 sudo umount
+    fi
+  ) 200>>"$LOCKFILE"
 }
 
 if [ $FLAGS_mount -eq $FLAGS_TRUE ]
 then
   setup_env
   echo "Make sure you run"
   echo "    $0 --unmount"
   echo "before deleting $FLAGS_chroot"
   echo "or you'll end up deleting $FLAGS_trunk too!"
   exit 0
@@ skipping 39 matching lines @@
 
 # Run command or interactive shell.  Also include the non-chrooted path to
 # the source trunk for scripts that may need to print it (e.g.
 # build_image.sh).
 sudo chroot "$FLAGS_chroot" sudo -i -u $USER $CHROOT_PASSTHRU \
   EXTERNAL_TRUNK_PATH="${FLAGS_trunk}" LANG=C "$@"
 
 # Remove trap and explicitly unmount
 trap - EXIT
 teardown_env